On Wed, 22 Mar 2017, Tony Lindgren wrote:

> We should use ack_invert as the int_read_and_clear() in the Motorola
> kernel tree does "ireg_val & ~mreg_val" before writing to the mask
> register.
> 
> Cc: Charles Keepax <ckee...@opensource.wolfsonmicro.com>
> Cc: Lee Jones <lee.jo...@linaro.org>
> Cc: Marcel Partap <mpar...@gmx.net>
> Cc: Michael Scott <michael.sc...@linaro.org>
> Tested-by: Sebastian Reichel <s...@kernel.org>
> Signed-off-by: Tony Lindgren <t...@atomide.com>
> ---
>  drivers/mfd/motorola-cpcap.c | 3 +++
>  1 file changed, 3 insertions(+)

Applied, thanks.

> diff --git a/drivers/mfd/motorola-cpcap.c b/drivers/mfd/motorola-cpcap.c
> --- a/drivers/mfd/motorola-cpcap.c
> +++ b/drivers/mfd/motorola-cpcap.c
> @@ -72,6 +72,7 @@ static struct regmap_irq_chip 
> cpcap_irq_chip[CPCAP_NR_IRQ_CHIPS] = {
>               .mask_base = CPCAP_REG_MIM1,
>               .use_ack = true,
>               .handle_reread = true,
> +             .ack_invert = true,
>       },
>       {
>               .name = "cpcap-m2",
> @@ -81,6 +82,7 @@ static struct regmap_irq_chip 
> cpcap_irq_chip[CPCAP_NR_IRQ_CHIPS] = {
>               .mask_base = CPCAP_REG_MIM2,
>               .use_ack = true,
>               .handle_reread = true,
> +             .ack_invert = true,
>       },
>       {
>               .name = "cpcap1-4",
> @@ -91,6 +93,7 @@ static struct regmap_irq_chip 
> cpcap_irq_chip[CPCAP_NR_IRQ_CHIPS] = {
>               .type_base = CPCAP_REG_INTS1,
>               .use_ack = true,
>               .handle_reread = true,
> +             .ack_invert = true,
>       },
>  };
>  

-- 
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog

Reply via email to