On 2017-03-31 17:29, Peter Rosin wrote:
> Hi!
> 
> Sorry for my incremental reviewing...
> 

Another incremental...

> On 2017-03-29 12:15, michael.henner...@analog.com wrote:
>> +
>> +    /* Now create an adapter for each channel */
>> +    for (num = 0; num < data->chip->nchans; num++) {
>> +            ret = i2c_mux_add_adapter(muxc, 0, num, 0);
>> +            if (ret) {
>> +                    dev_err(&client->dev,
>> +                            "failed to register multiplexed adapter %d\n",
>> +                            num);

Just a heads up, I submitted a series to remove a bunch of dev_err calls
when i2c_mux_add_adapter fails. See https://lkml.org/lkml/2017/4/3/115

You can remove this one as well.

And please use a subject of the form:
i2c: mux: ltc4306: <message>

Cheers,
peda

>> +                    goto add_adapter_failed;
>> +            }

Reply via email to