On 04/04/17 04:46 AM, Sagi Grimberg wrote:
>
>> + p2pmem_debugfs_root = debugfs_create_dir("p2pmem", NULL);
>> + if (!p2pmem_debugfs_root)
>> + pr_info("could not create debugfs entry, continuing\n");
>> +
>
> Why continue? I think it'd be better to just fail it.Yup, agreed. This should probably also be PTR_ERR as well. > Besides, this can be safely squashed into patch 1. Sure, the only real reason I kept it separate was it was authored by Steve Wise. Logan
