On Mon, Apr 3, 2017 at 11:16 PM, Matt Ranostay <[email protected]> wrote: > On Sun, Apr 2, 2017 at 10:29 AM, Andreas Klinger <[email protected]> wrote: >> Linus Walleij <[email protected]> schrieb am Sun, 02. Apr 16:56: >>> On Sun, Apr 2, 2017 at 11:32 AM, Jonathan Cameron <[email protected]> wrote: >>> > On 27/03/17 11:06, Andreas Klinger wrote: >>> >> While calculating the compensation of the humidity there are negative >>> >> values interpreted as unsigned because of unsigned variables used. >>> >> These values need to be casted to signed as indicated by the >>> >> documentation >>> >> of the sensor. >>> >> >>> >> Signed-off-by: Andreas Klinger <[email protected]> >>> > >>> > Looks superficially right to me, but would like an Ack from Linus Walleij. >>> >>> I didn't work on these calculations, only infrastructure for the driver >>> but FWIW: >>> Acked-by: Linus Walleij <[email protected]> >>> >>> Matt Ranostay @Intel is the person you probably want to ACK it though, >>> he added the humidity calculations :) >> >> It just turned out that there must be another error in the calculation. I'll >> fix >> and test it first. >> >> When i'm done i'll send a new version of the patch. >> > > Ok will hold off till review till the next patchset... BTW this > datasheet's calculations made my eyes bleed so it is quiet likely it > has bugs...
Hmm the datatypes you are casting to s32 are already signed integers... Interested in what you found on what the actual bug is. > > Thanks, > > Matt > >> Andreas >> >>> >>> Yours, >>> Linus Walleij >> >> -- >> -- >> To unsubscribe from this list: send the line "unsubscribe linux-iio" in >> the body of a message to [email protected] >> More majordomo info at http://vger.kernel.org/majordomo-info.html
