> +++ b/arch/ia64/kernel/module.c > @@ -153,7 +153,7 @@ slot (const struct insn *insn) > static int > apply_imm64 (struct module *mod, struct insn *insn, uint64_t val) > {
I have got another idea (after your clarification) for the suggested change. > - if (slot(insn) != 2) { > + if (slot(insn) != 1 && slot(insn) != 2) { + int const s = slot(insn); + if (s < 1 || s > 2) { Do run time characteristics matter for such a condition check here? > printk(KERN_ERR "%s: invalid slot number %d for IMM64\n", - mod->name, slot(insn)); + mod->name, s); > return 0; How do you think about my update suggestion for this function implementation? Regards, Markus