On 03/27/2017 08:23 PM, Darren Hart wrote: > On Tue, Mar 28, 2017 at 11:19:25AM +1100, Michael Ellerman wrote: >> Darren Hart <[email protected]> writes: >> >>> The use of $$OUTPUT in the target shell commands resulted in an empty >>> string followed by an absolute path for which mkdir failed: >>> >>> $ make -C tools/testing/selftests/futex >>> make: Entering directory >>> '/home/dvhart/source/linux/linux-pdx86/tools/testing/selftests/futex' >>> Makefile:36: warning: overriding recipe for target 'clean' >>> ../lib.mk:55: warning: ignoring old recipe for target 'clean' >>> for DIR in functional; do \ >>> BUILD_TARGET=$OUTPUT/$DIR; \ >>> mkdir $BUILD_TARGET -p; \ >>> make OUTPUT=$BUILD_TARGET -C $DIR all;\ >>> done >>> mkdir: cannot create directory ‘/functional’: Permission denied >>> >>> Replace $$OUTPUT with $(OUTPUT) when referring to the Makefile OUTPUT >>> variable. The above make command now completes successfully. >>> >>> Fixes: a8ba798bc8ec ("selftests: enable O and KBUILD_OUTPUT") >>> Signed-off-by: Darren Hart (VMware) <[email protected]> >>> Cc: [email protected] >>> Cc: [email protected] >>> Cc: Shuah Khan <[email protected]> >>> Cc: <[email protected]> # 4.10.x- >> >> The OUTPUT support only went into v4.11-rc1, so I don't see why you need >> a stable tag? > > Git spelunking failure on my part, you are correct. Please disregard the > stable > tag. > >> >> Change looks good though. >> > > Thank you for the review. >
Thanks for fixing this. Applied to linux-kselftest next after removing the stable tag. -- Shuah
