On Wed, 12 Apr 2017, Carlo Caione wrote:
> >> + ret = devm_led_classdev_register(&hdev->dev,
> >> &drvdata->kbd_backlight->cdev);
> >> + if (ret < 0) {
> >> + /* No need to have this still around */
> >> + devm_kfree(&hdev->dev, drvdata->kbd_backlight);
> >> + cancel_work_sync(&drvdata->kbd_backlight->work);
> >
> > Small nitpick, you don't need to call cancel_work_sync() here, nobody
> > could have called a worker. But OTOH, it doesn't hurt.
> >
> > Reviewed-by: Benjamin Tissoires <[email protected]>
>
> Thanks Benjamin. Who should pick this up?
I am going to.
I'll drop the cancel_work_sync() call while doing it, ok?
--
Jiri Kosina
SUSE Labs
