On Thu, Apr 13, 2017 at 8:47 PM, Shawn Guo <shawn...@kernel.org> wrote:
> On Thu, Apr 13, 2017 at 06:32:40AM -0700, Andrey Smirnov wrote:
>> Add node for U38, a 74LV595PW serial-in shift register that acts as a
>> GPIO expander on the board.
>>
>> Cc: yurov...@gmail.com
>> Cc: Sascha Hauer <ker...@pengutronix.de>
>> Cc: Fabio Estevam <fabio.este...@nxp.com>
>> Cc: Rob Herring <robh...@kernel.org>
>> Cc: Mark Rutland <mark.rutl...@arm.com>
>> Cc: Russell King <li...@armlinux.org.uk>
>> Cc: devicet...@vger.kernel.org
>> Cc: linux-kernel@vger.kernel.org
>> Cc: linux-arm-ker...@lists.infradead.org
>> Signed-off-by: Andrey Smirnov <andrew.smir...@gmail.com>
>> ---
>> arch/arm/boot/dts/imx7d-sdb.dts | 32 ++++++++++++++++++++++++++++++++
>> 1 file changed, 32 insertions(+)
>>
>> diff --git a/arch/arm/boot/dts/imx7d-sdb.dts
>> b/arch/arm/boot/dts/imx7d-sdb.dts
>> index 5be01a1..e0ff276 100644
>> --- a/arch/arm/boot/dts/imx7d-sdb.dts
>> +++ b/arch/arm/boot/dts/imx7d-sdb.dts
>> @@ -52,6 +52,30 @@
>> reg = <0x80000000 0x80000000>;
>> };
>>
>> + spi4 {
>> + compatible = "spi-gpio";
>> + pinctrl-names = "default";
>> + pinctrl-0 = <&pinctrl_spi1>;
>> + status = "okay";
>
> The 'status' is not needed in this case.
>
Missed that, will fix in v2.
>> + gpio-sck = <&gpio1 13 0>;
>> + gpio-mosi = <&gpio1 9 0>;
>> + cs-gpios = <&gpio1 12 0>;
>> + num-chipselects = <1>;
>> + #address-cells = <1>;
>> + #size-cells = <0>;
>> +
>> + gpio_spi: gpio_spi@0 {
>
> gpio-expander might be a better node name?
>
Yeah, I agree. I'll change it to extended_io: gpio-expander@0
("Extended IO" is how this part is called out on the schematic)
>> + compatible = "fairchild,74hc595";
>> + gpio-controller;
>> + #gpio-cells = <2>;
>> + reg = <0>;
>> + registers-number = <1>;
>> + /* Enable PERI_3V3, SENSOR_RST_B and HDMI_RST*/
>> + registers-default = /bits/ 8 <0x74>;
>
> I do not see this property is documented or supported by kernel.
My bad, some downstream properties leakage. Will remove in v2.
Thanks,
Andrey Smirnov
