On Fri, Apr 14, 2017 at 8:56 AM, Dong Aisheng <[email protected]> wrote: > On Thu, Apr 13, 2017 at 06:32:39AM -0700, Andrey Smirnov wrote: >> List GPR block as compatible "fsl,imx6q-iomuxc-gpr" to support drivers >> requesting it that way (PCIe driver is one example). >> >> Cc: [email protected] >> Cc: Sascha Hauer <[email protected]> >> Cc: Fabio Estevam <[email protected]> >> Cc: Rob Herring <[email protected]> >> Cc: Mark Rutland <[email protected]> >> Cc: Russell King <[email protected]> >> Cc: [email protected] >> Cc: [email protected] >> Cc: [email protected] >> Signed-off-by: Andrey Smirnov <[email protected]> >> --- >> arch/arm/boot/dts/imx7s.dtsi | 3 ++- >> 1 file changed, 2 insertions(+), 1 deletion(-) >> >> diff --git a/arch/arm/boot/dts/imx7s.dtsi b/arch/arm/boot/dts/imx7s.dtsi >> index 1a7058f..cc23478 100644 >> --- a/arch/arm/boot/dts/imx7s.dtsi >> +++ b/arch/arm/boot/dts/imx7s.dtsi >> @@ -491,7 +491,8 @@ >> }; >> >> gpr: iomuxc-gpr@30340000 { >> - compatible = "fsl,imx7d-iomuxc-gpr", "syscon"; >> + compatible = "fsl,imx7d-iomuxc-gpr", >> + "fsl,imx6q-iomuxc-gpr", "syscon"; > > This looks wrong to me. > mx7d-iomux-gpr gets a big difference from mx6q-iomux-gpr and mostly > not compatible. >
AFAICT, there are no upstream drivers that bind to that string directly and all of the "consumers" of this node request it as a syscon device. The only code I could find that does so and that is shared between i.MX7 and i.MX6Q is i.MX PCIe driver which distinguishes between variants based on its own compatibility string. Those two register files are different, true, but I don't think there are any users who try to use them as if they were the same/compatible. Thanks, Andrey Smirnov
