On Fri, Apr 14, 2017 at 11:01:25PM +0200, SF Markus Elfring wrote: > From: Markus Elfring <[email protected]> > Date: Fri, 14 Apr 2017 22:00:35 +0200 > > A multiplication for the size determination of a memory allocation > indicated that an array data structure should be processed. > Thus use the corresponding function "kcalloc". > > This issue was detected by using the Coccinelle software.
Unfortunately you write mostly cryptic commit messages. This does not answer for the main question - why this change is needed. Code looks okay, but you should explain in simple words why this is needed. Best regards, Krzysztof > > Signed-off-by: Markus Elfring <[email protected]> > --- > drivers/regulator/s2mps11.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/regulator/s2mps11.c b/drivers/regulator/s2mps11.c > index 7726b874e539..b4e588cce03d 100644 > --- a/drivers/regulator/s2mps11.c > +++ b/drivers/regulator/s2mps11.c > @@ -1162,7 +1162,7 @@ static int s2mps11_pmic_probe(struct platform_device > *pdev) > } > } > > - rdata = kzalloc(sizeof(*rdata) * rdev_num, GFP_KERNEL); > + rdata = kcalloc(rdev_num, sizeof(*rdata), GFP_KERNEL); > if (!rdata) > return -ENOMEM; > > -- > 2.12.2 >
