On 04/19/2017 12:36 AM, Joe Perches wrote: > On Tue, 2017-04-18 at 20:25 +0200, Marek Vasut wrote: >> On 04/18/2017 04:21 PM, Andrey Smirnov wrote: >>> As per request from Marek Vasut, change the following: >> >> Does that really have to be in the commit message ? ^_^' >> >>> - Replace indentation between type and name of local variable from >>> tabs to spaces >>> >>> - Replace magic number 0x1F with CFI_MFR_ATMEL macro >>> >>> - Replace variable 'tmp' with 'ret' and 'i' where appropriate >>> >>> - Reformat multi-line comments and add newlines where appropriate >>> >>> No functional change intended. >> >> Appreciated, thanks! > > trivia: > >>> diff --git a/drivers/mtd/devices/mtd_dataflash.c >>> b/drivers/mtd/devices/mtd_dataflash.c > [] >>> @@ -768,9 +771,9 @@ static struct flash_info *jedec_probe(struct spi_device >>> *spi) >>> jedec = jedec << 8; >>> jedec |= id[2]; >>> >>> - for (tmp = 0, info = dataflash_data; >>> - tmp < ARRAY_SIZE(dataflash_data); >>> - tmp++, info++) { >>> + for (i = 0, info = dataflash_data; >>> + i < ARRAY_SIZE(dataflash_data); >>> + i++, info++) { >>> if (info->jedec_id == jedec) { >>> pr_debug("%s: OTP, sector protect%s\n", >>> dev_name(&spi->dev), > > This loop could be written without the i variable. > > for (info = dataflash_data; > info < dataflash_data + ARRAY_SIZE(dataflash_data); > info++) { >
But in a separate patch please, so it's bisectable. I don't want to slap such change into this patch. -- Best regards, Marek Vasut