Hi Andy,
Thanks for the review.
On 04/19/2017 01:41 PM, Andy Shevchenko wrote:
On Fri, Apr 14, 2017 at 8:29 PM,
<[email protected]> wrote:
From: Kuppuswamy Sathyanarayanan <[email protected]>
According to Whiskey cove PMIC spec, bit 7 of GPIOIRQ0_REG belongs to
cove -> Cove
Will fix it in next version.
battery IO. So we should skip this bit when checking for GPIO irq pending
irq -> IRQ
Ditto.
status. Otherwise, wcove_gpio_irq_handler() might go into the infinite
loop until irq "pending" status becomes 0. This patch fixes this issue.
Ditto.
+#define GPIO_IRQ0_MASK 0x7f
+#define GPIO_IRQ1_MASK 0x3f
GENMASK()
Ditto.
- pending = p[0] | (p[1] << 8);
+ pending = (p[0] & GPIO_IRQ0_MASK) |
+ ((p[1] & GPIO_IRQ1_MASK) << 7);
I would leave this on one line despite 80 characters limit (actually
how long is it?).
It comes to 84 characters. Should I leave it as it is ?
--
Sathyanarayanan Kuppuswamy
Android kernel developer
