Hi! > > Maybe I figured it out. Unfortunately, it is only compile tested. Does > > it look approximately right? > > Yep that's definitely better. Just one thing missing (see below), > otherwise it looks good.
Thanks for review. Unfortunately it is still untested, so...
> > + if (res < 0)
> > + mtd->ecc_stats.failed++;
>
> else
> mtd->ecc_stats.corrected += res;
Ok, I copied this from tango_nand. I'll submit a patch to fix it
there...
> > +
> > + bitflips = max(res, bitflips);
> > + buf += pkt_size;
> > + ecc += ecc_size;
> > + }
> > +
> > + mtd_ooblayout_ecc(mtd, 1, &oobregion);
> > + BUG_ON(oobregion.length);
>
> Probably something you should check at registration time only.
Drive defensively, buy a tank ;-). Ok, I'll delete this one in final
version.
Pavel
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures)
http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
signature.asc
Description: Digital signature
