Arnaldo,
could you please take this one?
thanks,
jirka
On Thu, Apr 20, 2017 at 11:24:30AM +0200, Jiri Olsa wrote:
> Recent commit broke command name strip in perf_event__get_comm_ids
> function. It replaced left to right search for '\n' with rtrim,
> which actually does right to left search. It occasionally caught
> earlier '\n' and kept trash in the command name.
>
> Keeping the ltrim, but moving back the left to right '\n' search
> instead of the rtrim.
>
> Fixes: bdd97ca63faa ("perf tools: Refactor the code to strip command name
> with {l,r}trim()")
> Signed-off-by: Jiri Olsa <[email protected]>
> Cc: David Ahern <[email protected]>
> Cc: Namhyung Kim <[email protected]>
> Cc: Peter Zijlstra <[email protected]>
> Cc: Taeung Song <[email protected]>
> Cc: Jin Yao <[email protected]>
> Link: http://lkml.kernel.org/n/[email protected]
> ---
> tools/perf/util/event.c | 9 ++++++++-
> 1 file changed, 8 insertions(+), 1 deletion(-)
>
> diff --git a/tools/perf/util/event.c b/tools/perf/util/event.c
> index cf457ef534da..1a9164a816d9 100644
> --- a/tools/perf/util/event.c
> +++ b/tools/perf/util/event.c
> @@ -138,8 +138,15 @@ static int perf_event__get_comm_ids(pid_t pid, char
> *comm, size_t len,
> ppids = strstr(bf, "PPid:");
>
> if (name) {
> + char *nl;
> +
> name += 5; /* strlen("Name:") */
> - name = rtrim(ltrim(name));
> + name = ltrim(name);
> +
> + nl = strchr(name, '\n');
> + if (nl)
> + *nl = '\0';
> +
> size = strlen(name);
> if (size >= len)
> size = len - 1;
> --
> 2.9.3
>
