On Tue, May 9, 2017 at 5:15 PM, Eric W. Biederman <ebied...@xmission.com> wrote: > Kees Cook <keesc...@chromium.org> writes: >> kernel/kexec_file.c:33:13: warning: array ‘kexec_purgatory’ assumed to >> have one element >> char __weak kexec_purgatory[]; >> ^~~~~~~~~~~~~~~ > > Nor does "void *kexec_purgatory" as that says at the address known as > kexec_purgatory is a void pointer not a blob a bytes that can be used > for something interesting. > > Better to get rid of the __weak and deal with that fallout.
Agreed. This is actually pretty easy, since only x86 and PPC use kexec_file, and both define purgatories. I'll send an updated patch. Thanks! -Kees -- Kees Cook Pixel Security
