On 18.05.2017 19:37, Radim Krčmář wrote: > get_msr() of MSR_EFER is currently always going to succeed, but static > checker doesn't see that far. > > Don't complicate stuff and just use 0 for the fallback -- it means that > the feature is not present. > > Reported-by: Dan Carpenter <[email protected]> > Signed-off-by: Radim Krčmář <[email protected]> > --- > arch/x86/kvm/emulate.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/x86/kvm/emulate.c b/arch/x86/kvm/emulate.c > index c25cfaf584e7..0816ab2e8adc 100644 > --- a/arch/x86/kvm/emulate.c > +++ b/arch/x86/kvm/emulate.c > @@ -4173,7 +4173,7 @@ static int check_dr_write(struct x86_emulate_ctxt *ctxt) > > static int check_svme(struct x86_emulate_ctxt *ctxt) > { > - u64 efer; > + u64 efer = 0; > > ctxt->ops->get_msr(ctxt, MSR_EFER, &efer); > >
Reviewed-by: David Hildenbrand <[email protected]> -- Thanks, David
