On Fri, May 19, 2017 at 10:18:34AM -0400, Keith Busch wrote: > + > + if (ns->ctrl->quirks & NVME_QUIRK_PAGE_ALIGN) > + blk_queue_logical_block_size(ns->queue, ns->ctrl->page_size); > + else > + blk_queue_logical_block_size(ns->queue, bs);
Ugg. That will invalidate the layout of any existing fs (in case the device hasn't eaten it yet). It would also invalidate things like partitions tables, even if they are only used to share with windows.