On 4/4/07, Jan Engelhardt <[EMAIL PROTECTED]> wrote:
On Apr 4 2007 12:00, Randy Dunlap wrote:
>
>> +static int __init fpga_init(void)
>> +{
>> + if (machine_is_omap_h4()
>> + || machine_is_omap_h3()
>> + || machine_is_omap_h2()
>> + || machine_is_omap_perseus2()
>> + )
>
>Perhaps there is nothing in CodingStyle for if () continuation
>lines. Looks like it is needed. This is ETOOMUCHINDENTATION by
>at least one tab. Should be more like:
>
>+ if (machine_is_omap_h4()
>+ || machine_is_omap_h3()
>+ || machine_is_omap_h2()
>+ || machine_is_omap_perseus2())
My stance, || goes at EOL, and final ) not standalone:
if (foo ||
bar ||
baz ||
etc)
do_something;
I personally ident multi-line conditionals in "if" and "while" with
tabs to the keyword level, then pad with spaces so 2nd+ line starts in
the same column as first part of the condition (i.e one column to the
right from opening paren). Logical operation goes to EOL.
Also with multi-line condition and single-line body I often use braces
to separate them better.
--
Dmitry
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
