On Sun, May 21, 2017 at 02:05:31AM +0900, Masahiro Yamada wrote:
> The combo of list_empty() and list_first_entry() can be replaced with
> list_first_entry_or_null().
>
> Signed-off-by: Masahiro Yamada <yamada.masah...@socionext.com>
> ---
>
> drivers/usb/mtu3/mtu3.h | 8 ++------
> 1 file changed, 2 insertions(+), 6 deletions(-)
>
> diff --git a/drivers/usb/mtu3/mtu3.h b/drivers/usb/mtu3/mtu3.h
> index aa6fd6a..7b6dc23 100644
> --- a/drivers/usb/mtu3/mtu3.h
> +++ b/drivers/usb/mtu3/mtu3.h
> @@ -356,12 +356,8 @@ static inline struct mtu3_ep *to_mtu3_ep(struct usb_ep
> *ep)
>
> static inline struct mtu3_request *next_request(struct mtu3_ep *mep)
> {
> - struct list_head *queue = &mep->req_list;
> -
> - if (list_empty(queue))
> - return NULL;
> -
> - return list_first_entry(queue, struct mtu3_request, list);
> + return list_first_entry_or_null(&mep->req_list, struct mtu3_request,
> + list);
Even better, why is this an inlined function at all? Why not just have
it "open coded" everywhere it is used?
thanks,
greg k-h
