On Thu, May 18, 2017 at 11:46:25AM +0300, Valentin Sitdikov wrote: > This patch adds documentation for the max7360 bindings. > The max7360 is multifunctional device containing gpio, keypad, pwm and rotary > encoder submodules.
Wrap your lines. > > Signed-off-by: Valentin Sitdikov <[email protected]> > Signed-off-by: Andrei Dranitca <[email protected]> > --- This is v2, but isn't marked that way and doesn't have a change log. > Documentation/devicetree/bindings/mfd/max7360.txt | 72 > +++++++++++++++++++++++ > 1 file changed, 72 insertions(+) > create mode 100644 Documentation/devicetree/bindings/mfd/max7360.txt > > diff --git a/Documentation/devicetree/bindings/mfd/max7360.txt > b/Documentation/devicetree/bindings/mfd/max7360.txt > new file mode 100644 > index 0000000..fd83227 > --- /dev/null > +++ b/Documentation/devicetree/bindings/mfd/max7360.txt > @@ -0,0 +1,72 @@ > +* Maxim MAX7360 multi-function device > + > +The Maxim MAX7360 is a multifunction device which includes > +64 key switches, eight LED drivers/GPIOs, PWM intensity control, > +and rotary switch control. > + > +Required properties: > +- compatible: Should be the following: "maxim,max7360" > +- reg: Specifies the i2c slave address of the max7360 block. It can be 0x38, > 0x3a, 0x3c or 0x3e IIUC. line wrap. > + > +Optional properties: > +- interrupt-parent: Specifies the phandle of the interrupt controller to > which > + the interrupts from MAX7360 are routed to. > +- interrupt-names: list of "inti" and "intk" You are missing "interrupts" property. > +- interrupt-controller: Identifies the device as an interrupt controller. > +- #interrupt-cells : Number of cells to encode an interrupt source, shall > be 1. > + > +Examples: > + > +Without subnodes: > + max7360@38 { > + compatible = "maxim,max7360"; > + reg = <0x38>; > + interrupt-parent = <&gpio1>; > + interrupts = <23 IRQ_TYPE_LEVEL_LOW>, <23 IRQ_TYPE_LEVEL_LOW>; > + interrupt-names = "inti", "intk"; > + interrupt-controller; > + #interrupt-cells = <0x1>; > + > + }; > + > +With subnodes: > + max7360@38 { > + compatible = "maxim,max7360"; > + reg = <0x38>; > + interrupt-parent = <&gpio1>; > + interrupts = <23 IRQ_TYPE_LEVEL_LOW>; > + interrupt-names = "int-shared"; > + interrupt-controller; > + #interrupt-cells = <0x1>; > + > + gpio { > + compatible = "maxim,max7360-gpio"; > + gpio-controller; > + #gpio-cells = <0x2>; > + interrupt-controller; > + #interrupt-cells = <0x2>; > + interrupts = <0>; > + }; > + > + keypad { > + compatible = "maxim,max7360-keypad"; > + maxim,debounce_reg = /bits/ 8 <0xef>; > + maxim,ports_reg = /bits/ 8 <0xae>; > + linux,keymap = < MATRIX_KEY(0, 0, KEY_F5) > + MATRIX_KEY(1, 0, KEY_F4) >; > + keypad,num-rows = <2>; > + keypad,num-columns = <1>; > + interrupts = <1>; > + }; > + > + pwm { > + compatible = "maxim,max7360-pwm"; > + #pwm-cells = <0x2>; > + }; > + > + rotary_encoder { Still not right: rotary-encoder > + compatible = "maxim,max7360-rotary"; > + interrupts = <2>; > + }; > + > + }; > -- > 2.9.3 >
