On (05/23/17 22:38), Nick Desaulniers wrote: > > is_first_page() is only called from the macro VM_BUG_ON_PAGE() which is > only compiled in as a runtime check when CONFIG_DEBUG_VM is set, > otherwise is checked at compile time and not actually compiled in. > > Fixes the following warning, found with Clang: > > mm/zsmalloc.c:472:12: warning: function 'is_first_page' is not needed and > will not be emitted [-Wunneeded-internal-declaration] > static int is_first_page(struct page *page) > ^ > > Signed-off-by: Nick Desaulniers <[email protected]>
well, no objections from my side. MM seems to be getting more and more `__maybe_unused' annotations because of clang. Reviewed-by: Sergey Senozhatsky <[email protected]> -ss
