On Fri, May 26, 2017 at 7:15 PM, Hans de Goede <hdego...@redhat.com> wrote: > On x86 the axp288 PMIC provides an ACPI OpRegion handler, which must be > available before other drivers using it are loaded, which can only be > ensured if the mfd, OpRegionr and i2c-bus drivers are built in.
Extra "r" after OpRegion. > > Since the axp20x mfd code is used on non X86 too we cannot simply change > this into a bool, I've tried some Kconfig magic with if x86 but I could > not get this working correctly, so this commit just documents that this > should be builtin on x86, which fixes errors like these during boot: > > mmc0: SDHCI controller on ACPI [80860F14:00] using ADMA > ACPI Error: No handler for Region [REGS] (ffff93543b0cc3a8) > [UserDefinedRegion] > ACPI Error: Region UserDefinedRegion (ID=143) has no handler > (20170119/exfldio-2 > ACPI Error: Method parse/execution failed [\_SB.PCI0.I2C7.PMI5.GET] (Node > ffff93 > ACPI Error: Method parse/execution failed [\_SB.PCI0.SHC1._PS0] (Node > ffff93543b > acpi 80860F14:02: Failed to change power state to D0 > > Signed-off-by: Hans de Goede <hdego...@redhat.com> Lee, unfortunately I do not have any hardware with the AXP288, nor any other x86 tablets. As Hans mentioned, he is the only one improving the AXP288 part of the axp20x bunch of drivers, after the original authors dropped support for them. FWIW, Acked-by: Chen-Yu Tsai <w...@csie.org>
