On Tue, May 30, 2017 at 10:21:31AM -0400, Vivien Didelot wrote: > The taggers are currently responsible to free the original SKB if they > made a copy of it, or in case of error. > > This patch simplifies this by freeing the original SKB in the > dsa_slave_xmit caller if it differs from the return SKB (copy or NULL.)
So we have two different things here: 1) The tagger needs to drop the frame, because there is an error of some sort. 2) The tagger allocates a new skb for the frame. I think on error, the core code can drop the frame. If the tagger allocates a new skb, i think the tagger should be responsible for freeing to original. Andrew