2017-05-30 20:59 GMT+02:00 Andy Shevchenko <andy.shevche...@gmail.com>: > On Tue, May 30, 2017 at 11:58 AM, Bartosz Golaszewski <b...@bgdev.pl> wrote: >> Indicate the error number and make the message a bit more elaborate. > >> + dev_err(dev, >> + "adding gpiochip failed: %d (base: %d, >> ngpio: %d)\n", >> + ret, base, base < 0 ? ngpio : base + ngpio); > > You may consider to use > 'gpio_mockup_add' instead of 'adding gpiochip'. The latter points the > reader first to gpiochip_add family of functions while you run a > wrapper on top of it. >
But this message can also be emitted if the module params are invalid, in which case we don't even enter gpio_mockup_add(). Thanks, Bartosz
