On Wed, May 31, 2017 at 1:52 PM, Bartosz Golaszewski <b...@bgdev.pl> wrote: > 2017-05-30 20:52 GMT+02:00 Andy Shevchenko <andy.shevche...@gmail.com>: >> On Tue, May 30, 2017 at 11:58 AM, Bartosz Golaszewski <b...@bgdev.pl> wrote:
>>> + if (val != 0 && val != 1) >> >> Wouldn't be easier to have >> >> u8 rv; >> >> ret = kstrtu8_from_user(); >> if (ret >= 2) >> return ...; >> >> ? > > kstrtu8_from_user() doesn't return the converted value, so you won't > skip an if anyway Oh, yes. > and by using the int variant, we're avoiding a cast. > I'd prefer it this way frankly. Fair enough. (Though I would go with (val < 0 && val > 1) condition, of course it's matter of taste) -- With Best Regards, Andy Shevchenko
