On Fri, Jun 02, 2017 at 04:46:40PM +0300, Sagi Grimberg wrote:
>
>> switch (type) {
>> case NVME_NQN_NVME:
>> diff --git a/drivers/nvme/target/nvmet.h b/drivers/nvme/target/nvmet.h
>> index cfc5c7fb0ab7..4c6cb5ea1186 100644
>> --- a/drivers/nvme/target/nvmet.h
>> +++ b/drivers/nvme/target/nvmet.h
>> @@ -46,6 +46,7 @@ struct nvmet_ns {
>> u32 blksize_shift;
>> loff_t size;
>> u8 nguid[16];
>> + uuid_be uuid;
>
> This should be uuid_le to match the rest of NVMe.
It shouldn't. A RFC4122 uuid is always in "big endian" notation.
A little endiane uuid doesn't exist, it's called a GUID in Wintel
speak and isn't used in NVMe. My new uuid tree tries to fix up
the confusion by renaming our uuid_be type to uuid_t and uuid_le
to guid_t.
> Also, it would be useful to generate a random default with uuid_le_gen()
> for a better out-of-the-box experience.
That's actually a good point. Just needs to be uuid_be_gen/uuid_gen :)
