On Fri, 09 Jun 2017, Mani, Rajmohan wrote: > Hi Andy, > > > On Tue, Jun 06, 2017 at 03:59:49PM +0300, Andy Shevchenko wrote: > > > On Tue, Jun 6, 2017 at 2:55 PM, Rajmohan Mani > > <[email protected]> wrote: > > > > The TPS68470 device is an advanced power management unit that powers > > > > a Compact Camera Module (CCM), generates clocks for image sensors, > > > > drives a dual LED for Flash and incorporates two LED drivers for > > > > general purpose indicators. > > > > > > > > This patch adds support for TPS68470 mfd device. > > > > > > I dunno why you decide to send this out now, see my comments below. > > > > > > > +static int tps68470_chip_init(struct tps68470 *tps) { > > > > + unsigned int version; > > > > + int ret; > > > > > > > + /* FIXME: configure these dynamically */ > > > > > > So, what prevents you to fix this? > > > > Nothing I suppose. They're however not needed right now and can be > > implemented later on if they're ever needed. > > > > Ack
What does this mean? Is the plan to fix it or not? I don't want FIXMEs in the code that a) can be fixed right away or b) might never be fixed. -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog
