On 06/11/2017 08:22 PM, Kees Cook wrote: > On Sun, Jun 11, 2017 at 5:32 AM, Mickaël Salaün <[email protected]> wrote: >> Do not confuse the compiler with a semicolon preceding a block. Replace >> the semicolon with an empty block to avoid a warning: >> >> gcc -Wl,-no-as-needed -Wall -lpthread seccomp_bpf.c -o >> /.../linux/tools/testing/selftests/seccomp/seccomp_bpf >> In file included from seccomp_bpf.c:40:0: >> seccomp_bpf.c: In function ‘change_syscall’: >> ../kselftest_harness.h:558:2: warning: this ‘for’ clause does not guard... >> [-Wmisleading-indentation] >> for (; _metadata->trigger; _metadata->trigger = __bail(_assert)) >> ^ >> ../kselftest_harness.h:574:14: note: in expansion of macro >> ‘OPTIONAL_HANDLER’ >> } while (0); OPTIONAL_HANDLER(_assert) >> ^~~~~~~~~~~~~~~~ >> ../kselftest_harness.h:440:2: note: in expansion of macro ‘__EXPECT’ >> __EXPECT(expected, seen, ==, 0) >> ^~~~~~~~ >> seccomp_bpf.c:1313:2: note: in expansion of macro ‘EXPECT_EQ’ >> EXPECT_EQ(0, ret); >> ^~~~~~~~~ >> seccomp_bpf.c:1317:2: note: ...this statement, but the latter is >> misleadingly indented as if it is guarded by the ‘for’ >> { >> ^ >> >> Signed-off-by: Mickaël Salaün <[email protected]> >> Cc: Andy Lutomirski <[email protected]> >> Cc: Kees Cook <[email protected]> >> Cc: Shuah Khan <[email protected]> >> Cc: Will Drewry <[email protected]> > > Eek, thanks for catching that. :) > > Acked-by: Kees Cook <[email protected]> > > -Kees
Thanks. Ths fix is now in linux-kselftest next. -- Shuah
