* Enric Balletbo Serra <[email protected]> [170613 02:12]: > Hi Tony, > > 2017-06-13 9:35 GMT+02:00 Tony Lindgren <[email protected]>: > > * Enric Balletbo i Serra <[email protected]> [170612 14:28]: > >> The interrupt for power button is static data that comes from the > >> datasheet, there is no reason to need to define this value on every > >> board so seams reasonable put this information into the common tps65217 > >> file. > > > > I think there's a problem with these patches where we no longer know > > if the interrupts are wired up on a board. For example, if the USB PHY > > VBUS interrupt is not connected, the phy driver needs poll the > > cable state. > > > > Hmm, the tps65217 doesn't have a USB PHY like others tps, so not sure > how could affect this patch. Did you see this issue in any board that > uses tps65217 or any am335x based board which commonly uses this pmic?
Oh sorry I misread your patch. I thought you're removing the interrupts from dts, but you're just moving the dts entries to the common dtsi file :) So seems just fine with me. Regards, Tony
