On Fri, Jun 16, 2017 at 10:52 AM, Pali Rohár <pali.ro...@gmail.com> wrote: > On Friday 16 June 2017 15:35:39 Kai-Heng Feng wrote:
>> - if (kbd_token_bits != 0 || ret == 0) >> + /* >> + * If KBD_LED_OFF_TOKEN is the only token, >> + * consider there is no keyboard backlight. >> + */ >> + if ((kbd_token_bits & ~BIT(5)) != 0 || ret == 0) > > Should not this check to be rather: > > (kbd_token_bits != 0 && (kbd_token_bits & BIT(KBD_LED_OFF_TOKEN)) != > BIT(KBD_LED_OFF_TOKEN)) > > To express that we have at least one token at it is different from > KBD_LED_OFF_TOKEN token? Isn't the same to (kbd_token_bits ^ BIT(KBD_LED_OFF_TOKEN)) ? -- With Best Regards, Andy Shevchenko
