Hello Andy,
While preparing the update I suddenly found, that parport_serial.c is
not the right place for this card. Since there is no serial ports on
the board, it would be better to put it into parport_pc.c
So I'll resubmit the patch right after I get access to the hardware to
check, that I did it the right way.
On Sat, 17 Jun 2017 16:45:49 +0300
Andy Shevchenko <andy.shevche...@gmail.com> wrote:
> On Sat, Jun 17, 2017 at 4:02 PM, Sudip Mukherjee
> <sudipm.mukher...@gmail.com> wrote:
> > From: Alexander Gerasiov <g...@redlab-i.ru>
> >
> > WCH CH382L is a PCI-E adapter with 1 parallel port. It is similair
> > to CH382 but serial ports are not soldered on board. Detected as
> > Serial controller: Device 1c00:3050 (rev 10) (prog-if 05 [16850])
>
> > wch_ch382_2s1p,
> > + wch_ch382_0s1p,
>
> > /* wch_ch382_2s1p*/ { 1, { { 2, -1}, } },
> > + /* wch_ch382_0s1p*/ { 1, { { 2, -1}, } },
>
> > { 0x1c00, 0x3250, 0x1c00, 0x3250, 0, 0, wch_ch382_2s1p},
> > + { 0x1c00, 0x3050, 0x1c00, 0x3050, 0, 0, wch_ch382_0s1p},
>
> Just a nit, wouldn't be better to preserve alphanumerical sorting?
> (Exchange lines in above pairs)
>
> > + [wch_ch382_0s1p] = {
> ...
> > [sunix_2s1p] = {
>
> Similar here, though it's not visible in the patch.
>
--
Best regards,
Alexander Gerasiov
Contacts:
e-mail: g...@cs.msu.su Homepage: http://gerasiov.net Skype: gerasiov
PGP fingerprint: 04B5 9D90 DF7C C2AB CD49 BAEA CA87 E9E8 2AAC 33F1
