On Thu, Jun 22, 2017 at 02:30:10PM -0500, Gustavo A. R. Silva wrote:
> Value assigned to variable _ret_ at line 176 is overwritten
> a few lines below before it can be used. This makes such
> variable assignment useless.
>
> Addresses-Coverity-ID: 1403730
Get rid of this tag...
> Signed-off-by: Gustavo A. R. Silva <garsi...@embeddedor.com>
> ---
> drivers/edac/pnd2_edac.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/edac/pnd2_edac.c b/drivers/edac/pnd2_edac.c
> index c51ec73..d1de53e 100644
> --- a/drivers/edac/pnd2_edac.c
> +++ b/drivers/edac/pnd2_edac.c
> @@ -173,7 +173,7 @@ static int apl_rd_reg(int port, int off, int op, void
> *data, size_t sz, char *na
> edac_dbg(2, "Read %s port=%x off=%x op=%x\n", name, port, off, op);
> switch (sz) {
> case 8:
> - ret = sbi_send(port, off + 4, op, (u32 *)(data + 4));
> + sbi_send(port, off + 4, op, (u32 *)(data + 4));
... keep ret but OR it in with its previous value:
case 8:
ret = sbi_send(port, off + 4, op, (u32 *)(data + 4));
/* fall through */
case 4:
ret |= sbi_send(port, off, op, (u32 *)data);
> /* fall through */
> case 4:
> ret = sbi_send(port, off, op, (u32 *)data);
... and merge both into a single patch.
Thanks.
--
Regards/Gruss,
Boris.
Good mailing practices for 400: avoid top-posting and trim the reply.
