On Wed, 2017-06-28 at 06:37 -0700, Joe Perches wrote: > On Wed, 2017-06-28 at 15:17 +0200, Lubomir Rintel wrote: > > The mac80211_hwsim doesn't offer a way to disable the debugging > > output. > > Unfortunately, it's pretty chatty, dumping a lot of stuff into the > > message > > buffer. > > > > This patch changes it to use dyndbg for controlling the debug > > output. > > It's disabled by default, but can be enabled by a module parameter > > (1), > > at runtime (2) or persisted in modprobe.conf (3). > > > > (1) modprobe mac80211_hwsim dyndbg=+p > > (2) echo "module mac80211_hwsim +p" > > >/sys/kernel/debug/dynamic_debug/control > > (3) echo "options mac80211_hwsim dyndbg=+p" > > >>/etc/modprobe.d/my.conf > > I wonder about the value at all of the 2 forms: > > wiphy_dbg -> only with #define DEBUG or dynamic_debug > wiphy_debug -> always emitted at KERN_DEBUG > > Is there any real value in wiphy_debug? > > Should it just be converted to > > #define wiphy_debug wiphy_dbg
I don't think it should, there are some messages that we'd probably just have to give a higher priority if we did this. johannes
