On Fri, 2017-06-30 at 03:29 +0000, Dmitriy Cherkasov wrote: > After removing code which was premanently disabled with ifdefs, the > function ksocknal_csum() becomes just a wrapper for crc32_le(). Remove > this useless wrapper and instead call crc32_le() directly. > > This also resolves the following checkpatch warning which was > triggered by the dead code: > > WARNING: space prohibited before semicolon
Please use checkpatch on your proposed patches before sending them. > diff --git a/drivers/staging/lustre/lnet/klnds/socklnd/socklnd_lib.c > b/drivers/staging/lustre/lnet/klnds/socklnd/socklnd_lib.c [] > @@ -201,7 +201,7 @@ > if (fragnob > sum) > fragnob = sum; > > - conn->ksnc_rx_csum = ksocknal_csum(conn->ksnc_rx_csum, > + conn->ksnc_rx_csum = crc32_le(conn->ksnc_rx_csum, > iov[i].iov_base, > fragnob); Please realign the subsequent lines to the open parenthesis. > } > @@ -243,7 +243,7 @@ > if (fragnob > sum) > fragnob = sum; > > - conn->ksnc_rx_csum = ksocknal_csum(conn->ksnc_rx_csum, > + conn->ksnc_rx_csum = crc32_le(conn->ksnc_rx_csum, > base, fragnob); etc...
