On Mon, Jul 10, 2017 at 2:05 PM, <[email protected]> wrote: > From: Frank Rowand <[email protected]> > > Add nodes and properties to overlay_base and overlay dts files to > test for > - incorrect existing node name detection when overlay node name > has a unit-address > - adding overlay __symbols__ properties to live tree when an > overlay is added to the live tree > > Expected result from patch 2/3 is overlay will update the nodes and > properties for /testcase-data-2/fairway-1/ride@100/ > > Before patch 2/3 is applied:
This is good information, but what is patch 2/3 is less clear when this is committed. And 1 and 2 are probably stable material? I'd just note in this patch what the failures are and show before and after results in the patch that changes them. > Console error message near end of unittest: > OF: Duplicate name in fairway-1, renamed to "ride@100#1" > > $ cd /proc/device-tree/testcase-data-2/fairway-1/ > $ # extra node: ride@100#1 > $ ls > #address-cells linux,phandle phandle ride@200 > #size-cells name ride@100 status > compatible orientation ride@100#1 > $ cd /proc/device-tree/testcase-data-2/fairway-1/ride@100/ > $ ls track@3/incline_up > ls: track@3/incline_up: No such file or directory > $ ls track@4/incline_up > ls: track@4/incline_up: No such file or directory [...] > diff --git a/drivers/of/unittest-data/Makefile > b/drivers/of/unittest-data/Makefile > index 6e00a9c69e58..dae2fe23cd2e 100644 > --- a/drivers/of/unittest-data/Makefile > +++ b/drivers/of/unittest-data/Makefile > @@ -1,11 +1,13 @@ > obj-y += testcases.dtb.o > obj-y += overlay.dtb.o > obj-y += overlay_bad_phandle.dtb.o > +obj-y += overlay_bad_symbol.dtb.o > obj-y += overlay_base.dtb.o There's no reason for these all to be 1 per line. Also, should the overlay dtb's be conditioned on CONFIG_OF_OVERLAY (or whatever we call it)? But this is fine. That can all be a followup patch.
