On Tue, 04 Jul 2017, Gustavo A. R. Silva wrote: > Remove unnecessary static on local variable _chip_. > Such variable is initialized before being used, > on every execution path throughout the function. > The static has no benefit and, removing it reduces > the code size. > > This issue was detected using Coccinelle and the following semantic patch: > > @bad exists@ > position p; > identifier x; > type T; > @@ > > static T x@p; > ... > x = <+...x...+> > > @@ > identifier x; > expression e; > type T; > position p != bad.p; > @@ > > -static > T x@p; > ... when != x > when strict > ?x = e; > > In the following log you can see the difference in the code size and, > also a significant difference in the bss segment. This log is the output > of the size command, before and after the code change: > > before: > text data bss dec hex filename > 4188 1336 128 5652 1614 drivers/mfd/max8925-i2c.o > > after: > text data bss dec hex filename > 4135 1280 64 5479 1567 drivers/mfd/max8925-i2c.o > > Signed-off-by: Gustavo A. R. Silva <garsi...@embeddedor.com> > --- > drivers/mfd/max8925-i2c.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-)
Applied, thanks. -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog
