Hi Vladimir, Many thanks for the code review.
On 07/18/2017 09:48 PM, Vladimir Zapolskiy wrote: > Hello Gabriel, > > On 07/18/2017 10:53 AM, gabriel.fernan...@st.com wrote: >> From: Gabriel Fernandez <gabriel.fernan...@st.com> >> >> We need to export clk_gate_is_enabled() from clk framework, then > first of all let's clarify if you really need to export clk_gate_is_enabled() > from the CCF. Yes i really need to export clk_gate_is_enabled() >> to avoid compilation issue we have to rename clk_gate_is_enabled() >> in NXP LPC32xx clock driver. >> >> Signed-off-by: Gabriel Fernandez <gabriel.fernan...@st.com> >> --- >> drivers/clk/nxp/clk-lpc32xx.c | 4 ++-- >> 1 file changed, 2 insertions(+), 2 deletions(-) >> >> diff --git a/drivers/clk/nxp/clk-lpc32xx.c b/drivers/clk/nxp/clk-lpc32xx.c >> index 5b98ff9..1cc71ad 100644 >> --- a/drivers/clk/nxp/clk-lpc32xx.c >> +++ b/drivers/clk/nxp/clk-lpc32xx.c >> @@ -903,7 +903,7 @@ static void clk_gate_disable(struct clk_hw *hw) >> regmap_update_bits(clk_regmap, clk->reg, mask, val); >> } >> >> -static int clk_gate_is_enabled(struct clk_hw *hw) >> +static int __clk_gate_is_enabled(struct clk_hw *hw) >> { >> struct lpc32xx_clk_gate *clk = to_lpc32xx_gate(hw); >> u32 val; >> @@ -918,7 +918,7 @@ static int clk_gate_is_enabled(struct clk_hw *hw) >> static const struct clk_ops lpc32xx_clk_gate_ops = { >> .enable = clk_gate_enable, >> .disable = clk_gate_disable, >> - .is_enabled = clk_gate_is_enabled, >> + .is_enabled = __clk_gate_is_enabled, > In case if this change gets continuation, here I want to see the same > prefixes for all functions and no underscores, namely it shall be > * lpc32xx_clk_gate_enable(), > * lpc32xx_clk_gate_disable(), > * lpc32xx_clk_gate_is_enabled(). ok il will use same prefixes for all functions Best regards Gabriel. >> }; >> >> #define div_mask(width) ((1 << (width)) - 1) >> > -- > With best wishes, > Vladimir