> -----Original Message----- > From: Kalderon, Michal [mailto:[email protected]] > Sent: Wednesday, July 19, 2017 3:10 AM > To: Marciniszyn, Mike <[email protected]>; Ismail, Mustafa > <[email protected]>; [email protected]; > [email protected] > Cc: [email protected]; [email protected]; > [email protected]; [email protected]; Saleem, Shiraz > <[email protected]>; Amrani, Ram <[email protected]> > Subject: RE: [PATCH v2 2/2] RDMA/core: Initialize port_num in qp_attr > > > From: [email protected] [mailto:linux-rdma- > > [email protected]] On Behalf Of Marciniszyn, Mike > > > Initialize the port_num for iWARP in rdma_init_qp_attr. > > > > > > Fixes: 5ecce4c9b17b("Check port number supplied by user verbs cmds") > > > Cc: <[email protected]> # v2.6.14+ > > > Reviewed-by: Steve Wise <[email protected]> > > > Signed-off-by: Mustafa Ismail <[email protected]> > > > Why is the second patch required if you only validate the port_num if the > IB_QP_PORT mask is on? > Given the first patch [PATCH v2 1/2] RDMA/uverbs: Fix the check for port > number, this one seems redundant. Strictly speaking it is not required, but we felt it safer to always return a valid port number as is done in the IB case.
Regards, Mustafa
