From: Ismail, Mustafa <[email protected]>
Sent: Wednesday, July 19, 2017 5:38 PM
> > > > Fixes: 5ecce4c9b17b("Check port number supplied by user verbs cmds")
> > > > Cc: <[email protected]> # v2.6.14+
> > > > Reviewed-by: Steve Wise <[email protected]>
> > > > Signed-off-by: Mustafa Ismail <[email protected]>
> > >
> > Why is the second patch required if you only validate the port_num if the
> > IB_QP_PORT mask is on?
> > Given the first patch [PATCH v2 1/2] RDMA/uverbs: Fix the check for port
> > number, this one seems redundant.
> Strictly speaking it is not required, but we felt it safer to always return a
> valid port number
> as is done in the IB case.
It's not always initialized in the IB case either. More than that if at this
point you'll
initialize it for ib as well you'll get a failure on ib_modify_qp_is_ok, since
when
transitioning to RTR / RTS providing IB_QP_PORT is not a valid option.
We actually hit this issue when running rping over RoCE. (prior to your fix i
mean )
I agree that in general there's no real harm, but it seems a bit out of
context, and if we
make the change common for ib/iwarp we'll have to modify ib_modify_qp_is_ok
which
is written close to the spec.
thanks,
Michal
