Commit-ID:  aa5d1b81500e6059190f18fe25a7617682321910
Gitweb:     http://git.kernel.org/tip/aa5d1b81500e6059190f18fe25a7617682321910
Author:     Kees Cook <keesc...@chromium.org>
AuthorDate: Mon, 24 Jul 2017 11:35:48 -0700
Committer:  Ingo Molnar <mi...@kernel.org>
CommitDate: Tue, 25 Jul 2017 11:18:09 +0200

x86/asm: Add ASM_UNREACHABLE

This creates an unreachable annotation in asm for CONFIG_STACK_VALIDATION=y.
While here, adjust earlier uses of \t\n into \n\t.

Suggested-by: Josh Poimboeuf <jpoim...@redhat.com>
Signed-off-by: Kees Cook <keesc...@chromium.org>
Cc: Alexey Dobriyan <adobri...@gmail.com>
Cc: Andrew Morton <a...@linux-foundation.org>
Cc: Arnd Bergmann <a...@arndb.de>
Cc: Christoph Hellwig <h...@infradead.org>
Cc: David S. Miller <da...@davemloft.net>
Cc: Davidlohr Bueso <d...@stgolabs.net>
Cc: Elena Reshetova <elena.reshet...@intel.com>
Cc: Eric Biggers <ebigge...@gmail.com>
Cc: Eric W. Biederman <ebied...@xmission.com>
Cc: Greg KH <gre...@linuxfoundation.org>
Cc: Hans Liljestrand <ishkam...@gmail.com>
Cc: James Bottomley <james.bottom...@hansenpartnership.com>
Cc: Jann Horn <ja...@google.com>
Cc: Linus Torvalds <torva...@linux-foundation.org>
Cc: Manfred Spraul <manf...@colorfullife.com>
Cc: Peter Zijlstra <pet...@infradead.org>
Cc: Rik van Riel <r...@redhat.com>
Cc: Serge E. Hallyn <se...@hallyn.com>
Cc: Thomas Gleixner <t...@linutronix.de>
Cc: aroza...@redhat.com
Cc: ax...@kernel.dk
Cc: kernel-harden...@lists.openwall.com
Cc: linux-arch <linux-a...@vger.kernel.org>
Link: 
http://lkml.kernel.org/r/1500921349-10803-3-git-send-email-keesc...@chromium.org
Signed-off-by: Ingo Molnar <mi...@kernel.org>
---
 include/linux/compiler-gcc.h | 13 +++++++++----
 include/linux/compiler.h     |  3 +++
 2 files changed, 12 insertions(+), 4 deletions(-)

diff --git a/include/linux/compiler-gcc.h b/include/linux/compiler-gcc.h
index cd4bbe8..179375b 100644
--- a/include/linux/compiler-gcc.h
+++ b/include/linux/compiler-gcc.h
@@ -203,11 +203,16 @@
 
 #ifdef CONFIG_STACK_VALIDATION
 #define annotate_unreachable() ({                                      \
-       asm("%c0:\t\n"                                                  \
-           ".pushsection .discard.unreachable\t\n"                     \
-           ".long %c0b - .\t\n"                                        \
-           ".popsection\t\n" : : "i" (__LINE__));                      \
+       asm("%c0:\n\t"                                                  \
+           ".pushsection .discard.unreachable\n\t"                     \
+           ".long %c0b - .\n\t"                                        \
+           ".popsection\n\t" : : "i" (__LINE__));                      \
 })
+#define ASM_UNREACHABLE                                                        
\
+       "999:\n\t"                                                      \
+       ".pushsection .discard.unreachable\n\t"                         \
+       ".long 999b - .\n\t"                                            \
+       ".popsection\n\t"
 #else
 #define annotate_unreachable()
 #endif
diff --git a/include/linux/compiler.h b/include/linux/compiler.h
index 219f82f..641f591 100644
--- a/include/linux/compiler.h
+++ b/include/linux/compiler.h
@@ -185,6 +185,9 @@ void ftrace_likely_update(struct ftrace_likely_data *f, int 
val,
 #endif
 
 /* Unreachable code */
+#ifndef ASM_UNREACHABLE
+# define ASM_UNREACHABLE
+#endif
 #ifndef unreachable
 # define unreachable() do { } while (1)
 #endif

Reply via email to