On Fri, Jul 28, 2017 at 09:27:22AM +0000, Saurabh Singh wrote: > Hi Daniel, > > Thanks for your reply. > Currently I am using connector type 'Unknown' , and functionally it serves my > need. > Intention for sending this patch is that userspace tools should recognize SDI > drivers as SDI only. > Also, I see there are number of 'SDI' drivers getting developed 'under the > hood' in linux kernel. > This patch will benefit all of them.
Where are those? > It will be great if you could consider it. Well new uabi has very strict merge requirements: https://dri.freedesktop.org/docs/drm/gpu/drm-uapi.html#open-source-userspace-requirements I'll merge your patch as soon as all the pieces are ready. Just wanted to warn you that this is a _lot_ of work, and you probably want a really good reason. Thanks, Daniel > > Regards, > Saurabh > > -----Original Message----- > From: Daniel Vetter [mailto:daniel.vet...@ffwll.ch] On Behalf Of Daniel Vetter > Sent: Wednesday, July 26, 2017 8:08 PM > To: Saurabh Singh <saura...@xilinx.com> > Cc: linux-kernel@vger.kernel.org; dri-de...@lists.freedesktop.org; > airl...@linux.ie; Saurabh Singh <saura...@xilinx.com>; Dinesh Kumar > <dine...@xilinx.com> > Subject: Re: [PATCH] drm: adding SDI to drm_connector_enum_list > > On Wed, Jul 26, 2017 at 10:22:49AM +0530, Saurabh Sengar wrote: > > adding SDI to drm connector list > > > > Signed-off-by: Saurabh Sengar <saura...@xilinx.com> > > This is an uapi change, i.e. userspace needs to be updated. Do you _really_ > need this? I'd recommend to just use something existing (go with VIRTUAL > maybe, not sure). > > Either way, needs to come together with the actual users and userspace side > patches. If you really want this. > -Daniel > > --- > > drivers/gpu/drm/drm_connector.c | 1 + > > include/uapi/drm/drm_mode.h | 1 + > > 2 files changed, 2 insertions(+) > > > > diff --git a/drivers/gpu/drm/drm_connector.c > > b/drivers/gpu/drm/drm_connector.c index 2db7fb5..ea48ddb 100644 > > --- a/drivers/gpu/drm/drm_connector.c > > +++ b/drivers/gpu/drm/drm_connector.c > > @@ -86,6 +86,7 @@ static struct drm_conn_prop_enum_list > > drm_connector_enum_list[] = { > > { DRM_MODE_CONNECTOR_VIRTUAL, "Virtual" }, > > { DRM_MODE_CONNECTOR_DSI, "DSI" }, > > { DRM_MODE_CONNECTOR_DPI, "DPI" }, > > + { DRM_MODE_CONNECTOR_SDI, "SDI" }, > > }; > > > > void drm_connector_ida_init(void) > > diff --git a/include/uapi/drm/drm_mode.h b/include/uapi/drm/drm_mode.h > > index df0e350..9b8d204 100644 > > --- a/include/uapi/drm/drm_mode.h > > +++ b/include/uapi/drm/drm_mode.h > > @@ -247,6 +247,7 @@ struct drm_mode_get_encoder { > > #define DRM_MODE_CONNECTOR_VIRTUAL 15 > > #define DRM_MODE_CONNECTOR_DSI 16 > > #define DRM_MODE_CONNECTOR_DPI 17 > > +#define DRM_MODE_CONNECTOR_SDI 18 > > > > struct drm_mode_get_connector { > > > > -- > > 2.7.4 > > > > _______________________________________________ > > dri-devel mailing list > > dri-de...@lists.freedesktop.org > > https://lists.freedesktop.org/mailman/listinfo/dri-devel > > -- > Daniel Vetter > Software Engineer, Intel Corporation > http://blog.ffwll.ch > > > This email and any attachments are intended for the sole use of the named > recipient(s) and contain(s) confidential information that may be proprietary, > privileged or copyrighted under applicable law. If you are not the intended > recipient, do not read, copy, or forward this email message or any > attachments. Delete this email message and any attachments immediately. > -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch
