On Mon, 31 Jul 2017, Kees Cook wrote:

> The SELinux bprm_secureexec hook can be merged with the bprm_set_creds
> hook since it's dealing with the same information, and all of the details
> are finalized during the first call to the bprm_set_creds hook via
> prepare_binprm() (subsequent calls due to binfmt_script, etc, are ignored
> via bprm->called_set_creds).
> 
> Here, the test can just happen at the end of the bprm_set_creds hook,
> and the bprm_secureexec hook can be dropped.
> 
> Cc: Stephen Smalley <[email protected]>
> Signed-off-by: Kees Cook <[email protected]>
> Acked-by: Paul Moore <[email protected]>
> Tested-by: Paul Moore <[email protected]>
> Acked-by: Serge Hallyn <[email protected]>
> ---
>  security/selinux/hooks.c | 24 +++++-------------------
>  1 file changed, 5 insertions(+), 19 deletions(-)


Reviewed-by: James Morris <[email protected]>


-- 
James Morris
<[email protected]>

Reply via email to