On Mon, 31 Jul 2017, Kees Cook wrote: > The Smack bprm_secureexec hook can be merged with the bprm_set_creds > hook since it's dealing with the same information, and all of the details > are finalized during the first call to the bprm_set_creds hook via > prepare_binprm() (subsequent calls due to binfmt_script, etc, are ignored > via bprm->called_set_creds). > > Here, the test can just happen at the end of the bprm_set_creds hook, > and the bprm_secureexec hook can be dropped. > > Cc: Casey Schaufler <ca...@schaufler-ca.com> > Signed-off-by: Kees Cook <keesc...@chromium.org> > Acked-by: Serge Hallyn <se...@hallyn.com> > --- > security/smack/smack_lsm.c | 21 ++++----------------- > 1 file changed, 4 insertions(+), 17 deletions(-)
Reviewed-by: James Morris <james.l.mor...@oracle.com> -- James Morris <jmor...@namei.org>
