Hi Mel,

On Tue, Aug 01, 2017 at 11:30:55AM +0100, Mel Gorman wrote:
> On Tue, Aug 01, 2017 at 02:56:14PM +0900, Minchan Kim wrote:
> > This patch is ready for solving race problems caused by TLB batch.
> 
> s/is ready/is a preparatory patch/
> 
> > For that, we will increase/decrease TLB flush pending count of
> > mm_struct whenever tlb_[gather|finish]_mmu is called.
> > 
> > Before making it simple, this patch separates architecture specific
> > part and rename it to arch_tlb_[gather|finish]_mmu and generic part
> > just calls it.
> > 
> > It shouldn't change any behavior.
> > 
> > Cc: Ingo Molnar <[email protected]>
> > Cc: Russell King <[email protected]>
> > Cc: Tony Luck <[email protected]>
> > Cc: Martin Schwidefsky <[email protected]>
> > Cc: "David S. Miller" <[email protected]>
> > Cc: Heiko Carstens <[email protected]>
> > Cc: Yoshinori Sato <[email protected]>
> > Cc: Jeff Dike <[email protected]>
> > Cc: [email protected]
> > Cc: Nadav Amit <[email protected]>
> > Cc: Mel Gorman <[email protected]>
> > Signed-off-by: Minchan Kim <[email protected]>
> 
> You could alias arch_generic_tlb_finish_mmu as arch_tlb_gather_mmu
> simiilar to how other arch-generic helpers are done to avoid some
> #ifdeffery but otherwise

Good idea. With Andrew's suggestion, Nadav will resend whole series
including his patchset. I asked to him to fix it when he respin.

> 
> Acked-by: Mel Gorman <[email protected]>

Thanks for the review!

Reply via email to