Hi Thierry, On Fri, Aug 11, 2017 at 12:16:47AM +0200, Thierry Escande wrote: > From: Vincent Palatin <[email protected]> > > If we cannot communicate with the EC chip to detect the protocol version > and its features, it's very likely useless to continue. Else we will > commit all kind of uninformed mistakes (using the wrong protocol, the > wrong buffer size, mixing the EC with other chips). > > Signed-off-by: Vincent Palatin <[email protected]> > Signed-off-by: Thierry Escande <[email protected]>
Acked-by: Benson Leung <[email protected]> > --- > drivers/mfd/cros_ec.c | 6 +++++- > 1 file changed, 5 insertions(+), 1 deletion(-) > > diff --git a/drivers/mfd/cros_ec.c b/drivers/mfd/cros_ec.c > index b0ca5a4c..c5528ae 100644 > --- a/drivers/mfd/cros_ec.c > +++ b/drivers/mfd/cros_ec.c > @@ -112,7 +112,11 @@ int cros_ec_register(struct cros_ec_device *ec_dev) > > mutex_init(&ec_dev->lock); > > - cros_ec_query_all(ec_dev); > + err = cros_ec_query_all(ec_dev); > + if (err) { > + dev_err(dev, "Cannot identify the EC: error %d\n", err); > + return err; > + } > > if (ec_dev->irq) { > err = request_threaded_irq(ec_dev->irq, NULL, ec_irq_thread, > -- > 2.7.4 > -- Benson Leung Staff Software Engineer Chrome OS Kernel Google Inc. [email protected] Chromium OS Project [email protected]
signature.asc
Description: Digital signature
