On Fri, Aug 18, 2017 at 8:28 AM, Sean Paul <[email protected]> wrote: > On Thu, Aug 17, 2017 at 12:00:04PM -0700, John Stultz wrote: >> Currently the hikey dsi logic cannot generate accurate byte >> clocks values for all pixel clock values. Thus if a mode clock >> is selected that cannot match the calculated byte clock, the >> device will boot with a blank screen. >> >> This patch uses the new mode_valid callback (many thanks to >> Jose Abreu for upstreaming it!) to ensure we don't select >> modes we cannot generate. >> >> Also, since the ade crtc code will adjust the mode in mode_set, >> this patch also adds a mode_fixup callback which we use to make >> sure we are validating the mode clock that will eventually be >> used. >> >> Cc: Daniel Vetter <[email protected]> >> Cc: Jani Nikula <[email protected]> >> Cc: Sean Paul <[email protected]> >> Cc: David Airlie <[email protected]> >> Cc: Rob Clark <[email protected]> >> Cc: Xinliang Liu <[email protected]> >> Cc: Xinliang Liu <[email protected]> >> Cc: Rongrong Zou <[email protected]> >> Cc: Xinwei Kong <[email protected]> >> Cc: Chen Feng <[email protected]> >> Cc: Jose Abreu <[email protected]> >> Cc: Archit Taneja <[email protected]> >> Cc: [email protected] >> Signed-off-by: John Stultz <[email protected]> > > Hi John, > Thanks for continuing to send new versions for this patch. It looks good to me > (there's a small spelling mistake in a comment below that perhaps can be fixed > when applied, no biggy). > > Reviewed-by: Sean Paul <[email protected]>
Thanks so much for the review! I really appreciate it! -john
