Hi Johannes, 2017-08-03 19:09 GMT+09:00 Johannes Thumshirn <jthumsh...@suse.de>: > We have lots of dead defines and macros in drivers, lets offer users a way > to detect and eventually remove them. > > Signed-off-by: Johannes Thumshirn <jthumsh...@suse.de> > --- > scripts/Makefile.extrawarn | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/scripts/Makefile.extrawarn b/scripts/Makefile.extrawarn > index fb3522fd8702..8ab8bc91da55 100644 > --- a/scripts/Makefile.extrawarn > +++ b/scripts/Makefile.extrawarn > @@ -25,6 +25,7 @@ warning-1 += -Wold-style-definition > warning-1 += $(call cc-option, -Wmissing-include-dirs) > warning-1 += $(call cc-option, -Wunused-but-set-variable) > warning-1 += $(call cc-option, -Wunused-const-variable) > +warning-1 += $(call cc-option, -Wunused-macros) > warning-1 += $(call cc-disable-warning, missing-field-initializers) > warning-1 += $(call cc-disable-warning, sign-compare)
This makes W=1 too noisy. For example, drivers often define unused register macros for completeness. I do not think it is too bad in my opinion. Perhaps, should it be moved to warning-2 ? -- Best Regards Masahiro Yamada
