Linus Torvalds <torva...@linux-foundation.org> writes: > On Thu, Aug 24, 2017 at 11:40 AM, Eric W. Biederman > <ebied...@xmission.com> wrote: >> >> Here is my tested version of the patch. > > Can you please take my cleanups to devpts_ptmx_path() too?
Let met take a look. > Those 'goto err' statements are disgusting, when a plain 'return > -ERRNO' works cleaner. Yes those look like good cleanups. I had tried to preserve the original logic in devpts_ptmx_path from devpts_acquire to make it easier to see if I had goofed. But that out and out failed so cleanups so the code is easier to read look like a very good thing. > And that "struct file *filp = NULL;" is bogus - you added the NULL > initialization because you mis-used "filp" early, and with that fixed > it's just garbage. Actually the NULL initialization is a hold over from the original version of that function. But I agree without it gcc could have caught my use of the wrong variable, so removing it looks like a good idea. > Other than that, it looks fine to me. Thanks. I will respin and retest and see where things are at. Eric
