[PATCH 1/2] ALSA: us122l: Use common error handling code in us122l_create_card()

[SF Markus Elfring]

From: Markus Elfring <elfr...@users.sourceforge.net>
Date: Wed, 6 Sep 2017 14:45:09 +0200

Add a jump target so that a bit of exception handling can be better reused
at the end of this function.

This issue was detected by using the Coccinelle software.

Signed-off-by: Markus Elfring <elfr...@users.sourceforge.net>
---
 sound/usb/usx2y/us122l.c | 10 ++++++----
 1 file changed, 6 insertions(+), 4 deletions(-)

diff --git a/sound/usb/usx2y/us122l.c b/sound/usb/usx2y/us122l.c
index b49d6e953d52..159da1f3924e 100644
--- a/sound/usb/usx2y/us122l.c
+++ b/sound/usb/usx2y/us122l.c
@@ -508,8 +508,7 @@ static bool us122l_create_card(struct snd_card *card)
                err = us122l_create_usbmidi(card);
        if (err < 0) {
                snd_printk(KERN_ERR "us122l_create_usbmidi error %i \n", err);
-               us122l_stop(us122l);
-               return false;
+               goto stop;
        }
        err = usb_stream_hwdep_new(card);
        if (err < 0) {
@@ -518,10 +517,13 @@ static bool us122l_create_card(struct snd_card *card)
                list_for_each(p, &us122l->midi_list)
                        snd_usbmidi_disconnect(p);
 
-               us122l_stop(us122l);
-               return false;
+               goto stop;
        }
        return true;
+
+stop:
+       us122l_stop(us122l);
+       return false;
 }
 
 static void snd_us122l_free(struct snd_card *card)
-- 
2.14.1