On Tue, 12 Sep 2017, Joe Lawrence wrote:
> > On Thu, Aug 31, 2017 at 04:37:41PM -0400, Joe Lawrence wrote:
> >> +void *__klp_shadow_get_or_alloc(void *obj, unsigned long id, void *data,
> >> + size_t size, gfp_t gfp_flags, bool warn_on_exist)
> >> +{
> >> + struct klp_shadow *new_shadow;
> >> + void *shadow_data;
> >> + unsigned long flags;
> >> +
> >> + /* Check if the shadow variable if <obj, id> already exists */
> >
> > Grammar fix: either
> >
> > s/if the shadow variable//
> >
> > or
> >
> > s/if <obj, id>//
> >
> > Otherwise:
> >
> > Acked-by: Josh Poimboeuf <jpoim...@redhat.com>
> >
>
> If this is the only outstanding nit, can this be fixed up on merge or
> does it need a new patch spin?
No need to resend just because of this, I'll fix this up manually once
applying.
Thanks,
--
Jiri Kosina
SUSE Labs
